Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance regresssion #9045

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fix performance regresssion #9045

merged 1 commit into from
Aug 11, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 11, 2022

Revert BibDatabase to previous state

Fixes #9041

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Revert bibdatabasemode to previous state

Fixes #9041
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 11, 2022
@HoussemNasri
Copy link
Member

LGTM! I tested it locally and the performance is back to normal.

@Siedlerchr Siedlerchr merged commit 60f5c1b into main Aug 11, 2022
@Siedlerchr Siedlerchr deleted the fixPerformance branch August 11, 2022 15:34
Siedlerchr added a commit that referenced this pull request Aug 12, 2022
…ledgeItems

* upstream/main:
  Fixed table update in eft preferences (#9051)
  Keep EOL setting at backups (#9048)
  ExternalFileTypes singleton refactor (#9044)
  Fix dead link (#9047)
  Fix performance regresssion (#9045)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit to koppor/jabref that referenced this pull request Aug 14, 2022
* upstream/main: (31 commits)
  Citavi Importer - Import all knowledge items (JabRef#9043)
  Fixed table update in eft preferences (JabRef#9051)
  Keep EOL setting at backups (JabRef#9048)
  ExternalFileTypes singleton refactor (JabRef#9044)
  Fix dead link (JabRef#9047)
  Fix performance regresssion (JabRef#9045)
  Update javafx to 18.02
  import citavi knowledge items (JabRef#9033)
  Fix .gitattributes for CHANGELOG.md
  [GSOC22] - B - Implement merging fields in the three way merge UI (JabRef#9022)
  [GSOC22] - A - Implement a fully functional three way merge UI (JabRef#8945)
  Change button label from "Return to JabRef" to "Return to library" (JabRef#9039)
  Bump postgresql from 42.4.0 to 42.4.1 (JabRef#9036)
  Bump org.javamodularity.moduleplugin from 1.8.11 to 1.8.12 (JabRef#9037)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 (JabRef#9035)
  Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 in /buildSrc (JabRef#9038)
  Update Gradle Wrapper from 7.5 to 7.5.1. (JabRef#9034)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (JabRef#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  ...
Siedlerchr added a commit that referenced this pull request Aug 21, 2022
* upstream/main:
  Fix performance regresssion (#9045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading large database takes way too long after commit 5.7--2022-08-01--8389254
3 participants